fix(controlplane): allow workflow-scoped API tokens in find-or-create#3123
Merged
migmartri merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
AI Session AnalysisMissing AI Coding SessionsWe detected commits in this PR that were AI-assisted, but the matching Chainloop Trace session(s) could not be found in Chainloop. Please make sure the AI coding session evidence has been sent by the Chainloop CLI, or add the Learn more about Chainloop Trace. Powered by Chainloop and Chainloop Trace |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
FindOrCreateWorkflow rejected every workflow-scoped API token, including calls that targeted the token's own workflow. The check now compares the request's workflow name against the token's scope and only forbids cross-workflow calls. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: 3c7034e8-bf8f-485b-a6ee-5b8628b963ef, 72212199-5c7a-45d2-ab00-3ae15eb8e651
migmartri
force-pushed
the
fix/workflow-scoped-tokens-find-or-create
branch
from
fdc4bf8 to
b60dd79
Compare
javirln
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttestationService.FindOrCreateWorkflowrejected every workflow-scoped API token (token.WorkflowID != nil), so a token issued for workflowXcould not even callFindOrCreateagainstXitself. The check now compares the request's workflow name to the token's ownWorkflowNameand only forbids cross-workflow calls.This contribution was made with the assistance of AI (Claude Code).